Skip to content

Replace TRAVIS_* envvars with GITHUB_ envvars #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

Replace TRAVIS_* envvars with GITHUB_ envvars #243

merged 3 commits into from
Oct 14, 2025

Conversation

@twodarek
Copy link
Contributor

@twodarek twodarek commented Oct 10, 2025 •
edited
Loading

We no longer use TravisCI, so these envvars had their values patched over from GITHUB envvars. It makes more sense to use the correct envvars initially.

Part of: https://github.com/Expensify/Expensify/issues/514581#issuecomment-3329458321

Explanation of Change

Mapping:

TRAVIS_RUNNING - (bool) getenv('GITHUB_SHA'))
TRAVIS_COMMIT - GITHUB_SHA
TRAVIS_BRANCH - GITHUB_REF

Related Issues

Deployment

  • I followed the steps in the README to ensure this PR is deployed properly

@twodarek twodarek mentioned this pull request Oct 10, 2025
Closed
1 task
@twodarek twodarek requested review from flodnv and iwiznia October 10, 2025 20:56
@twodarek
Copy link
Contributor Author

twodarek commented Oct 10, 2025

Tagging @iwiznia and @flodnv in on this PR because they were in the previous review (#238), which was closed in favor of this PR

@twodarek twodarek changed the title We no longer use TravisCI, so these envvars had their values patched over from GITHUB envvars. It makes more sense to use the correct envvars initially. Replace TRAVIS_* envvars with GITHUB_ envvars Oct 10, 2025
@twodarek twodarek force-pushed the twodarek-cleanup-old-travisci branch from 5976ece to 6a0db18 Compare October 10, 2025 21:04
flodnv
flodnv approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@flodnv flodnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry you lost time on the weirdness in the other PR.

@iwiznia is ooo, feel free to merge without his review.

FYI, your versioning here may conflict with @justinpersaud's versioning in #242

@twodarek
Copy link
Contributor Author

twodarek commented Oct 14, 2025

@flodnv Thanks for the heads up! @justinpersaud and I worked it out, his #242 is moving to 2.2.6, so I'm keeping 2.2.5 🙂

Merging. Thanks!

@twodarek twodarek merged commit 6ed4c92 into main Oct 14, 2025
2 checks passed
@twodarek twodarek deleted the twodarek-cleanup-old-travisci branch October 14, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flodnv flodnv flodnv approved these changes

@iwiznia iwiznia Awaiting requested review from iwiznia

Assignees

@twodarek twodarek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twodarek @flodnv